On 04/18/2012 05:46 PM, Daniel Vetter wrote: > On Wed, Apr 18, 2012 at 01:31:59PM +0900, Joonyoung Shim wrote: >> DRM_MODE_PLANE_EVENT is similar to DRM_MODE_PAGE_FLIP_EVENT but it is >> for a plane. The setplane ioctl (DRM_IOCTL_MODE_SETPLANE) needs to >> provide the event such as DRM_MODE_PAGE_FLIP_EVENT. The setplane ioctl >> can change the framebuffer of plane but user can't know completion of >> changing the framebuffer of plane via event. If DRM_MODE_PLANE_EVENT is >> added, we can also do pageflip of a plane. >> >> Signed-off-by: Joonyoung Shim<jy0922.shim at samsung.com> >> Signed-off-by: Kyungmin Park<kyungmin.park at samsung.com> > If I understand the current kms api correctly, set_plane is akin to > set_base and should not generate an asynchronous flip completion event. To > do that we need a new pageflip ioctl which changes a complete set of fb + > planes + any crtc attributes that might be in an atomic fashion. At which > point we can just reuse the existing page flip event mechanism.
It seems better way to add new pageflip ioctl for plane. I will try it. Thanks for review.
