Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] PM: runtime: inaccurate Fixes trailers and caller notes in commit message --
commit 48057d65d03972fb7f912d84a7a35bf1b15bba82 Author: Frank Li <[email protected]> > PM: runtime: fix stub pm_runtime_get_if_in_use() for !CONFIG_PM > > The stub for pm_runtime_get_if_in_use() under !CONFIG_PM currently > returns -EINVAL. The real implementation returns: > 1 - device is active and its usage counter is non-zero (bumped) > 0 - device is not in use or not active (counter not bumped) > -EINVAL - runtime PM disabled for this device > > When CONFIG_PM is not set every device is permanently "active" and > always considered "in use", so the stub must return 1, mirroring > __pm_runtime_resume() which already returns 1 in the same build. > > Returning -EINVAL breaks callers that test the return value with > comparisons other than "!= 0 / == 0": > > drivers/gpu/drm/i915/intel_runtime_pm.c: > if (intel_runtime_pm_get_if_in_use(rpm)) > which wraps to: ret = pm_runtime_get_if_in_use(); return ret > 0; > With -EINVAL the wrapper returns false, causing an incorrect error > path in the GT fence revocation code. > > drivers/gpu/drm/xe/xe_pm.c: > if (pm_runtime_get_if_in_use(xe->drm.dev) > 0) > With -EINVAL the condition is false; xe_pm_runtime_get_if_in_use() > returns false, so callers believe the device is not usable. > > drivers/gpu/drm/gma500/power.c: > return pm_runtime_get_if_in_use(dev) == 1; > -EINVAL != 1, so the helper always returns false when !CONFIG_PM. > > drivers/gpu/drm/imagination/pvr_power.c: > if (pm_runtime_get_if_in_use(...) <= 0) > -EINVAL <= 0 is true, so the driver always takes the "requeue" error > path instead of proceeding with the active device. > > sound/soc/sof/debug.c: > if (pm_runtime_get_if_in_use(sdev->dev) == 1) > -EINVAL != 1, so d3_prevented is never set, corrupting exception > debug accounting. > > drivers/iommu/mtk_iommu.c: > if (pm_runtime_get_if_in_use(dom->plat_dev->dev) <= 0) > -EINVAL <= 0 skips the TLB flush, leaving stale IOMMU mappings. > > drivers/iommu/rockchip-iommu.c: > Three call sites use WARN_ON_ONCE(err < 0) or similar patterns. > -EINVAL < 0 triggers a spurious WARNING on every call. > > drivers/media/i2c/isl7998x.c: > if (pm_runtime_get_if_in_use(dev) <= 0) (two call sites) > -EINVAL <= 0 causes the driver to always skip register programming > when !CONFIG_PM. > > drivers/media/platform/rockchip/rkisp1/rkisp1-debug.c: > if (pm_runtime_get_if_in_use(dev) <= 0) (two call sites) > -EINVAL <= 0 prevents any debug statistics from being collected. > > Fixes: 9d58aa46291d ("drm/i915: Fix the GT fence revocation runtime PM logic") > Fixes: cbb6a7413b17 ("drm/xe: Introduce xe_pm_runtime_get_noresume for inner > callers") > Fixes: 672c473576ca ("drm/gma500: Rewrite power management code") > Fixes: 727538a4bbff ("drm/imagination: Implement power management") > Fixes: b30289e7fa92 ("ASoC: SOF: Fix runtime pm usage counter balance after > fw exception") > Fixes: c0b57581b73b ("iommu/mediatek: Add power-domain operation") > Fixes: 0f181d3cf7d9 ("iommu/rockchip: Add runtime PM support") > Fixes: 51ef2be546e2 ("media: i2c: isl7998x: Add driver for Intersil ISL7998x") > Fixes: cbb819c363c5 ("media: rkisp1: debug: Collect input status by sampling > ISP_FLAGS_SHD") > Signed-off-by: Frank Li <[email protected]> [Severity: Low] Are the Fixes tags and caller descriptions in the commit message accurate? The !CONFIG_PM stub for pm_runtime_get_if_in_use() returning -EINVAL was introduced in a436b6a19f57 ("PM / runtime: Add new helper for conditional usage count incrementation"), which is missing from the Fixes tags. For i915, __intel_runtime_pm_get_if_active() guards the call to pm_runtime_get_if_in_use() with if (IS_ENABLED(CONFIG_PM)), so the !CONFIG_PM stub is never called there, and 9d58aa46291d ("drm/i915: Fix the GT fence revocation runtime PM logic") switched i915_vma_revoke_fence() to with_intel_runtime_pm_if_active, which calls pm_runtime_get_if_active(). For imagination, DRM_POWERVR in drivers/gpu/drm/imagination/Kconfig has "depends on PM" (added in 727538a4bbff ("drm/imagination: Implement power management")), so pvr_power.c cannot be built with !CONFIG_PM. Also, several of the remaining Fixes tags do not point to the commits that introduced the affected checks: - In drivers/gpu/drm/xe/xe_pm.c, the pm_runtime_get_if_in_use() > 0 check in xe_pm_runtime_get_if_in_use() was added by 3b85b7bcccf4 ("drm/xe: Fix display runtime_pm handling"), whereas cbb6a7413b17 ("drm/xe: Introduce xe_pm_runtime_get_noresume for inner callers") only added a caller. - In drivers/iommu/rockchip-iommu.c, 0f181d3cf7d9 ("iommu/rockchip: Add runtime PM support") used boolean checks where -EINVAL evaluated to true; the WARN_ON_ONCE() checks on negative or non-positive returns were added by 3fc7c5c0cff3 ("iommu/rockchip: Handle errors returned from PM framework"). - In drivers/media/platform/rockchip/rkisp1/rkisp1-debug.c, the first pm_runtime_get_if_in_use() <= 0 check in rkisp1_debug_dump_regs() was added earlier by 2a6b586035ec ("media: rkisp1: debug: Add debugfs files to dump core and ISP registers"). -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=2
