On Thu, Nov 12, 2026 at 09:37:11PM +0900, Eliot Courtney wrote: > Add support for reserving of ranges of IDs, with a usage in nova-core > for channel IDs. > > The bitmap and `IdPool` parts from earlier versions are in v7.4-rc1 > now, and this version has the remaining patches: exact `IdPool` > capacities and `ChannelIdPool`. > > Channel ID tracking is needed for allotting ranges of channel IDs to > vGPU guests, and later for regular host channel ID reservation. > nova-core needs allocation of a contiguous sequence of IDs with a > specific length and sometimes a specific alignment [1]. > > About the tradeoffs between different data structures: > - IDA/xarray do not support allocating a contiguous sequence of IDs > (ida_alloc_range() allocates a single ID within a range, not a contiguous > sequence). > - A maple tree works, but is not as good a fit. The ID space is small > (limited to 2048) and aligned allocation needs an alloc_range()+erase() > retry > loop (plus a Mutex around it, or new mas_empty_area() bindings) that > essentially reimplements bitmap_find_next_zero_area(). See the maple tree > version at [2]. For 2048 IDs a bitmap is also considerably faster and > smaller > [3]. > - The bitmap API natively supports aligned contiguous area allocation > (bitmap_find_next_zero_area()). > > This is based on drm-rust-next.
Reviewed-by: Yury Norov <[email protected]> > [1]: > https://lore.kernel.org/all/[email protected]/ > [2]: > https://lore.kernel.org/all/[email protected]/ > [3]: https://lore.kernel.org/all/[email protected]/ Maybe add this links in the commit message too? > Signed-off-by: Eliot Courtney <[email protected]> > --- > Changes in v12: > - Drop the patches that were applied to drm-rust-next and driver-core > - Rebase on drm-rust-next > - Drop the zero capacity part of the patch #1 commit message (Yury) > - Add reviewed-by tags > - Link to v11: > https://patch.msgid.link/[email protected] > > Changes in v11: > - Rebase on drm-rust-next (pre-reqs are merged now) > - Split patch #1 by subsystem (Danilo). Just splitting with no actual > changes, so I kept the reviewed-by tags on the new patches > - Add reviewed-by tags > - Link to v10: > https://patch.msgid.link/[email protected] > > Changes in v10: > - Drop the patches that were applied to rust-next > - Rebase on drm-rust-next (plus pre-reqs) > - Use a capacity of 1 instead of 0 in the grow_request() example in > patch #2 (Yury) > - Convert the remaining Alignment::new() users in nova-core in patch #1 > - Link to v9: > https://patch.msgid.link/[email protected] > > Changes in v9: > - Rebase on drm-rust-next > - Moved cv! to a separate series which this now depends on > - Reference Link: tag from the text + indent code in patch #4 commit > message (Miguel) > - Add reviewed-by tags > - Link to v8: > https://patch.msgid.link/[email protected] > > Changes in v8: > - Clarify overflow cases in patch #2 (Alex) > - Replace nz! with generalized cv! macro (Gary) > - Add cv! macro to prelude > - Split SizeConstants and adding new constants patch (Alex) > - Move alignment size constants conersions patch (Alex) > - Drop NonZero on IdPool, fix grow_request instead (Alice, Alex) > - Add shrink/grow doctests (Burak) > - Link to v7: > https://patch.msgid.link/[email protected] > > Changes in v7: > - Add nz! macro for compile time NonZero > - Implement SizeConstants for Alignment + add sub 1k size constants > - Use Alignment constants + nz! in this series > - Add final patch converting existing callers to use Alignment constants > - Rename alloc_area/release_area -> reserve_ids / release_ids > - Link to v6: > https://patch.msgid.link/[email protected] > > Changes in v6: > - Take a NonZero nbits in `next_zero_area_off`, `set` and `clear` (Yury) > - Remove `UnusedArea`, `IdPool::alloc_area` now allocates directly (Yury) > - Add patch: take a NonZero capacity in `IdPool::with_capacity()` > - Add patch: do not round the capacity up to `BitmapVec::MAX_INLINE_LEN`, > which also removes the bounds check in `ChannelIdPool::alloc_area` > - Add more testing of Drop for `ChannelIdPool` (Yury) > - Link to v5: > https://patch.msgid.link/[email protected] > > Changes in v5: > - `bitmap_assert!` i32::MAX length for Bitmap::from_raw* (Yury) > - Only run overflow check on 32-bit (Yury) > - Link to v4: > https://patch.msgid.link/[email protected] > > Changes in v4: > - Add `next_zero_area_off` to match C code (Yury) > - Replace overflow checks to match C code in bitmap-for-next. > - Tighten `Bitmap` unsafe contract to disallow Bitmaps larger than i32::MAX > - Link to v3: > https://patch.msgid.link/[email protected] > > Changes in v3: > - Use `Alignment` type in id_pool and bitmap (Alice) > - Remove hang check on the basis that it's extraordinarily rare. > - Link to v2: > https://patch.msgid.link/[email protected] > > Changes in v2: > - Collected Alice's Reviewed-by on patch 1. > - Address Yury's comments w.r.t. using __bitmap_set etc directly. > - Address Yury's comments w.r.t. following the C names > - Additionally check for an overflow case that causes a hang > - Added more info to cover letter + patch 4 w.r.t. channel ID allottment > requirements > - Add align parameter to ChannelIdPool::alloc_area() plus an aligned > allocation test > - Add missing INVARIANT comment when constructing UnusedArea > - Link to v1: > https://patch.msgid.link/[email protected] > > --- > Eliot Courtney (2): > rust: id_pool: do not round capacity up to BitmapVec::MAX_INLINE_LEN > gpu: nova-core: add ChannelIdPool > > drivers/gpu/nova-core/gpu.rs | 2 + > drivers/gpu/nova-core/gpu/channel.rs | 198 > +++++++++++++++++++++++++++++++++++ > rust/kernel/id_pool.rs | 38 +++++-- > 3 files changed, 232 insertions(+), 6 deletions(-) > --- > base-commit: 6e557330b874b0e1fdd03e8fe4c438f36c93eefa > change-id: 20260608-chid-18fa943c6d6c > > Best regards, > -- > Eliot Courtney <[email protected]>
