Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [High] drm/bridge: dw-hdmi-qp: missing DRM_DISPLAY_CONNECTOR Kconfig select --
commit 2fdd511539969260584719b2d1604f9b1b9ed26e Author: Joachim Eastwood <[email protected]> drm/bridge: synopsys: dw-hdmi-qp: Attach the next bridge in the chain This commit implements drm_bridge_funcs.attach for dw-hdmi-qp to look up and attach the next bridge connected to output port 1. > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c > b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c > index eed249aca1e23..200229e5d9afc 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c [ ... ] > @@ -1024,7 +1028,33 @@ static void dw_hdmi_qp_bridge_hpd_disable(struct > drm_bridge *bridge) > hdmi->phy.ops->disable_hpd(hdmi, hdmi->phy.data); > } > > +static int dw_hdmi_qp_bridge_attach(struct drm_bridge *bridge, > + struct drm_encoder *encoder, > + enum drm_bridge_attach_flags flags) > +{ > + struct dw_hdmi_qp *hdmi = bridge->driver_private; > + struct device_node *remote __free(device_node) = > + of_graph_get_remote_node(hdmi->dev->of_node, > + DW_HDMI_QP_OUTPUT_PORT, -1); > + > + /* > + * The HDMI connector node is optional. When present, chain its bridge > + * so that properties such as ddc-i2c-bus, hpd-gpios and supplies are > + * honoured by the DRM bridge connector. > + */ > + if (!remote) > + return 0; > + > + struct drm_bridge *next_bridge __free(drm_bridge_put) = > + of_drm_find_and_get_bridge(remote); > + if (!next_bridge) > + return -EPROBE_DEFER; [Severity: High] Should DRM_DW_HDMI_QP (or ROCKCHIP_DW_HDMI_QP) select DRM_DISPLAY_CONNECTOR in Kconfig? All in-tree RK3576 and RK3588 board device trees wire port 1 to an "hdmi-connector" node, which is handled by display-connector.c under CONFIG_DRM_DISPLAY_CONNECTOR. Neither DRM_DW_HDMI_QP nor ROCKCHIP_DW_HDMI_QP selects DRM_DISPLAY_CONNECTOR, so configs that previously worked without it will now have of_drm_find_and_get_bridge() return NULL and defer probe forever, preventing rockchip_drm_bind() from binding the display subsystem. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=2
