Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [High] drm/msm/dp: msm_dp_irq_hpd_handle() ignores link status changes in MST mode --
commit 15b01d9a837796474eb17d695117c65eb5290f5f Author: Abhinav Kumar <[email protected]> drm/msm/dp: add HPD callback for dp MST This commit adds an HPD IRQ handler and poll_hpd_irq topology callback for DisplayPort MST, routing IRQ_HPD events to the MST module when MST is active. > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > b/drivers/gpu/drm/msm/dp/dp_display.c > index 7bf24cd2bae25..75eaf739b86f0 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -529,6 +529,11 @@ static int msm_dp_irq_hpd_handle(struct > msm_dp_display_private *dp) > dp->msm_dp_display.connector_type, > dp->link->sink_count); > > + if (dp->msm_dp_display.mst_active) { > + msm_dp_mst_display_hpd_irq(&dp->msm_dp_display); > + return 0; > + } > + > /* check for any test request issued by sink */ > rc = msm_dp_link_process_request(dp->link); > if (!rc) { [Severity: High] Does returning early here skip link status checks and retraining when MST is active? drm_dp_mst_hpd_irq_handle_event() only processes the sink count in esi[0] and sideband message readiness (DP_DOWN_REP_MSG_RDY and DP_UP_REQ_MSG_RDY) in esi[1]. Because msm_dp_irq_hpd_handle() returns before calling msm_dp_link_process_request() and msm_dp_display_handle_irq_hpd(), link service events in esi[3] (such as LINK_STATUS_CHANGED) and lane status losses reported via IRQ_HPD are ignored, leaving the mainlink untrained and MST displays blank if link synchronization is lost. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=21
