On 19/11/2026 00:32, Gregory Williams wrote:
> Add documentation to describe Versal AI Engine device tree bindings. AI
> Engine is a tile array based processor with many cores and local memory
> cache. Data routing between the cores is done through internal switches,
> interface tiles are used to connect to external sources such as memory
> or PL. Configuration registers of the device are accessed through a
> memory mapped AXI address space.
> 
> Signed-off-by: Gregory Williams <[email protected]>
> ---
>  .../bindings/soc/xilinx/xlnx,ai-engine.yaml   | 61 +++++++++++++++++++

Soc is dumping ground of things which do not have clear function. This
has a clear function, so place it with other DSP/accel/NPU.

Subject - you almost hit the bingo. Missing only schema and YAML for the
full one.

A nit, subject: drop second/last, redundant "DT bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v7.1-rc7/source/Documentation/devicetree/bindings/submitting-patches.rst#L23

>  1 file changed, 61 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/soc/xilinx/xlnx,ai-engine.yaml
> 
> diff --git a/Documentation/devicetree/bindings/soc/xilinx/xlnx,ai-engine.yaml 
> b/Documentation/devicetree/bindings/soc/xilinx/xlnx,ai-engine.yaml
> new file mode 100644
> index 000000000000..6c97b5f0fb03
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/xilinx/xlnx,ai-engine.yaml

Please read writing bindings document. Filename must match compatible.

> @@ -0,0 +1,61 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)

Why not using recommended license? Why doing this differently?

> +# Copyright(C) 2026 Advanced Micro Devices, Inc. All rights reserved.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/xilinx/xlnx,ai-engine.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: AMD AI Engine for Versal SoCs
> +
> +maintainers:
> +  - Gregory Williams <[email protected]>
> +
> +description:
> +  The AMD AI Engine is a tile processor with many cores (up to 400) that
> +  can run in parallel with some devices containing local cache (memory 
> tiles).
> +  The data routing between cores is configured through internal switches, and
> +  shim tiles interface with external interconnect, such as memory or PL.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - xlnx,versal2-aieml
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  clock-names:
> +    const: aclk0

Drop clock name. If you have to use output clock name as input name,
then it's just incorrect or incomplete, thus just drop it.

> +
> +  xlnx,firmware-device-id:

You don't get device identifiers, sorry. See writing bindings.

> +    description:
> +      Device identifier as defined by Versal firmware interface. This value 
> is
> +      passed unchanged to firmware calls.
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - clock-names
> +  - xlnx,firmware-device-id
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    soc {
> +      #address-cells = <2>;
> +      #size-cells = <2>;
> +
> +      ai_engine: ai-engine@20000000000 {

Don't use your own names. It is not an engine.

Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
If you cannot find a name matching your device, please check in kernel
sources for similar cases or you can grow the spec (via pull request to
DT spec repo).

> +        compatible = "xlnx,versal2-aieml";
> +        reg = <0x200 0x00 0x01 0x00>;
> +        clocks = <&aclk0>;
> +        clock-names = "aclk0";
> +        xlnx,firmware-device-id = <0x18224072>;
> +      };
> +    };


Best regards,
Krzysztof

Reply via email to