Hi Andreas,

On Thu, 19 Nov 2026 at 22:50, Andreas Kemnade <[email protected]> wrote:
> On Thu, 19 Nov 2026 14:40:38 +0100
> Geert Uytterhoeven <[email protected]> wrote:
>
> > OMAP2+ clock handling uses of_clk_get_from_provider() to obtain clocks
> > used for power management, so the latter show up as "deviceless" in the
> > consumer column of the clk_summary file in debugfs.
> >
> > Fix this by using dev_clk_get_from_provider() instead, letting us pass
> > the consumer device, too.
> >
> > Signed-off-by: Geert Uytterhoeven <[email protected]>
> > ---
> > Compile-tested only.
> >
> > The first change is probably OK.  The second change may fail if anything
> > in the oh->od->pdev->dev chain is not available yet at this point.
>
> Test on OMAP3:

Thanks for testing!

> --- clk-old     2026-11-19 22:44:59.810807920 +0100
> +++ clk-new     2026-11-19 22:26:52.862531880 +0100
> @@ -1,17 +1,17 @@
>                                   enable  prepare  protect                    
>             duty  hardware                            connection
>     clock                          count    count    count        rate   
> accuracy phase  cycle    enable   consumer                         id
>  
> ---------------------------------------------------------------------------------------------------------------------------------------------
> - oscillator                          0       0        0        26000000    0 
>          0     50000      Y   deviceless                      
> of_clk_get_from_provider
> + oscillator                          0       0        0        26000000    0 
>          0     50000      Y   deviceless                      
> dev_clk_get_from_provider
>                                                                               
>                               deviceless                      no_connection_id
> - secure_32k_fck                      0       1        0        32768       0 
>          0     50000      Y   deviceless                      
> of_clk_get_from_provider
> + secure_32k_fck                      0       1        0        32768       0 
>          0     50000      Y   deviceless                      
> dev_clk_get_from_provider
>                                                                               
>                               deviceless                      no_connection_id
> -    wdt1_fck                         0       0        0        32768       0 
>          0     50000      Y      deviceless                      
> of_clk_get_from_provider
> +    wdt1_fck                         0       0        0        32768       0 
>          0     50000      Y      deviceless                      
> dev_clk_get_from_provider
>                                                                               
>                                  deviceless                      
> no_connection_id
>      gpt12_fck                        0       1        0        32768       0 
>          0     50000      Y      48304000.timer                  fck
>                                                                               
>                                  48304000.target-module          fck
> -                                                                             
>                                  deviceless                      
> of_clk_get_from_provider
> +                                                                             
>                                  deviceless                      
> dev_clk_get_from_provider
>                                                                               
>                                  deviceless                      
> no_connection_id
> - dummy_ck                            0       0        0        0           0 
>          0     50000      Y   deviceless                      
> of_clk_get_from_provider
> + dummy_ck                            0       0        0        0           0 
>          0     50000      Y   deviceless                      
> dev_clk_get_from_provider
>                                                                               
>                               deviceless                      no_connection_id
>   mcbsp_clks                          0       5        0        0           0 
>          0     50000      Y   deviceless                      mcbsp_clks
>                                                                               
>                               deviceless                      mcbsp_clks

Hmm, so the passed device is always NULL, and thus there is no point
in making the change.
Do you know if these come from the first or second change in my patch
(I guess the second)?

Thanks again!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Reply via email to