On Tue, Aug 28, 2012 at 3:03 AM, Paul Menzel <paulepanter at users.sourceforge.net> wrote: > Dear Alex, > > > Am Montag, den 27.08.2012, 16:25 -0400 schrieb alexdeucher at gmail.com: >> From: Alex Deucher <alexander.deucher at amd.com> >> >> Power gating is per crtc pair, but the powergating registers >> should be called individually. The hw handles power up/down >> properly. The pair is powered up if either crtc in the pair >> is powered up and the pair is not powered down until both >> crtcs in the pair are powered down. This simplifies >> programming and should save power additional power. > > it would be nice, if you could provide some numbers if the last > statement is true.
I haven't checked to see how much it saves but the way the previous code worked the pair never actually got power gated. Alex > >> Signed-off-by: Alex Deucher <alexander.deucher at amd.com> >> Cc: stable at vger.kernel.org >> >> --- >> drivers/gpu/drm/radeon/atombios_crtc.c | 22 ++-------------------- >> 1 files changed, 2 insertions(+), 20 deletions(-) > > [?] > > Acked-by: Paul Menzel <paulepanter at users.sourceforge.net> > > > Thanks, > > Paul