I wanted to work on something similar this week, cause we need some updates for SI on this.
So thx, you saved me some work here. And both patches are: Reviewed-by: Christian K?nig <christian.koenig at amd.com> On 29.07.2012 16:02, Marek Ol??k wrote: > Setting those flags has no effect anywhere else. > --- > radeon/radeon_surface.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/radeon/radeon_surface.c b/radeon/radeon_surface.c > index c80f7f4..5800c33 100644 > --- a/radeon/radeon_surface.c > +++ b/radeon/radeon_surface.c > @@ -385,14 +385,7 @@ static int r6_surface_init(struct radeon_surface_manager > *surf_man, > /* tiling mode */ > mode = (surf->flags >> RADEON_SURF_MODE_SHIFT) & RADEON_SURF_MODE_MASK; > > - /* always enable z & stencil together */ > - if (surf->flags & RADEON_SURF_ZBUFFER) { > - surf->flags |= RADEON_SURF_SBUFFER; > - } > - if (surf->flags & RADEON_SURF_SBUFFER) { > - surf->flags |= RADEON_SURF_ZBUFFER; > - } > - if (surf->flags & RADEON_SURF_ZBUFFER) { > + if (surf->flags & (RADEON_SURF_ZBUFFER | RADEON_SURF_SBUFFER)) { > /* zbuffer only support 1D or 2D tiled surface */ > switch (mode) { > case RADEON_SURF_MODE_1D: