On Fri, May 4, 2012 at 11:25 AM, Ilija Hadzic <ihadzic at research.bell-labs.com> wrote: > connector_names table is just a repeat of information that > already exists in drm_connector_enum_list and the same string > can be retrieved using drm_get_connector_name function. > > Nuke the redundant table and use the proper function to retrieve > the connector name. > > Signed-off-by: Ilija Hadzic <ihadzic at research.bell-labs.com>
Reviewed-by: Alex Deucher <alexander.deucher at amd.com> > --- > ?drivers/gpu/drm/radeon/radeon_display.c | ? 20 +------------------- > ?1 files changed, 1 insertions(+), 19 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/radeon_display.c > b/drivers/gpu/drm/radeon/radeon_display.c > index 8086c96..60aecc5 100644 > --- a/drivers/gpu/drm/radeon/radeon_display.c > +++ b/drivers/gpu/drm/radeon/radeon_display.c > @@ -572,24 +572,6 @@ static const char *encoder_names[36] = { > ? ? ? ?"TRAVIS", > ?}; > > -static const char *connector_names[15] = { > - ? ? ? "Unknown", > - ? ? ? "VGA", > - ? ? ? "DVI-I", > - ? ? ? "DVI-D", > - ? ? ? "DVI-A", > - ? ? ? "Composite", > - ? ? ? "S-video", > - ? ? ? "LVDS", > - ? ? ? "Component", > - ? ? ? "DIN", > - ? ? ? "DisplayPort", > - ? ? ? "HDMI-A", > - ? ? ? "HDMI-B", > - ? ? ? "TV", > - ? ? ? "eDP", > -}; > - > ?static const char *hpd_names[6] = { > ? ? ? ?"HPD1", > ? ? ? ?"HPD2", > @@ -612,7 +594,7 @@ static void radeon_print_display_setup(struct drm_device > *dev) > ? ? ? ?list_for_each_entry(connector, &dev->mode_config.connector_list, head) > { > ? ? ? ? ? ? ? ?radeon_connector = to_radeon_connector(connector); > ? ? ? ? ? ? ? ?DRM_INFO("Connector %d:\n", i); > - ? ? ? ? ? ? ? DRM_INFO(" ?%s\n", > connector_names[connector->connector_type]); > + ? ? ? ? ? ? ? DRM_INFO(" ?%s\n", drm_get_connector_name(connector)); > ? ? ? ? ? ? ? ?if (radeon_connector->hpd.hpd != RADEON_HPD_NONE) > ? ? ? ? ? ? ? ? ? ? ? ?DRM_INFO(" ?%s\n", > hpd_names[radeon_connector->hpd.hpd]); > ? ? ? ? ? ? ? ?if (radeon_connector->ddc_bus) { > -- > 1.7.8.5 > > _______________________________________________ > dri-devel mailing list > dri-devel at lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel