On 12/11/13 01:17 PM, Keith Packard wrote: > I stole the conditional for _X_ATTRIBUTE_PRINTF from xproto and > changed the name to _DRM_ATTRIBUTE_PRINTF to avoid future conflicts. > > Signed-off-by: Keith Packard <keithp at keithp.com> > --- > xf86drm.h | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/xf86drm.h b/xf86drm.h > index 1e763a3..0bf205f 100644 > --- a/xf86drm.h > +++ b/xf86drm.h > @@ -92,8 +92,15 @@ extern "C" { > typedef unsigned int drmSize, *drmSizePtr; /**< For mapped > regions */ > typedef void *drmAddress, **drmAddressPtr; /**< For mapped regions > */ > > +/* Added in X11R6.9, so available in any version of modular xproto */
You should drop that line - those comments are used for us to figure out which xproto version to list in the pkg-config requirements when using newer _X_* macros out of Xfuncproto.h, so doesn't make sense here. Also be warned that using a macro name starting with an _ will cause you to get complaints about violating the "reserved for the implementation" rule in the ANSI/ISO C standards from people who consider the implementation to solely be the compiler, not the OS. https://bugs.freedesktop.org/show_bug.cgi?id=70686 for example. -- -Alan Coopersmith- alan.coopersmith at oracle.com Oracle Solaris Engineering - http://blogs.oracle.com/alanc