On Mon, Apr 7, 2014 at 4:03 PM, Daniel Vetter <daniel at ffwll.ch> wrote: > On Mon, Apr 7, 2014 at 7:23 PM, Rob Clark <robdclark at gmail.com> wrote: >> On Mon, Apr 7, 2014 at 6:05 AM, Thierry Reding <thierry.reding at gmail.com> >> wrote: >>> On Fri, Mar 28, 2014 at 10:04:09PM +0100, Daniel Vetter wrote: >>>> On Tue, Mar 18, 2014 at 05:22:57PM -0700, Matt Roper wrote: >>>> > Add cursor plane as a parameter to drm_crtc_init() and update all >>>> > existing DRM drivers to use a helper-provided primary plane. Passing >>>> > NULL for this parameter indicates that there is no hardware cursor >>>> > supported by the driver and no cursor plane should be provided to >>>> > userspace. >>>> > >>>> > Signed-off-by: Matt Roper <matthew.d.roper at intel.com> >>>> >>>> Ok, cursor planes. I've poked around in this a lot and unfortunately I >>>> don't think we can achieve nirvana :( >>> [...] >>>> - For the pixel format I think it's ok to always assume RGBA. >>> >>> How so? We do have hardware on Tegra that doesn't support RGBA cursors >>> and if at all possible I'd very much like to support that as well. New >>> generations can do RGBA but still support the old pixel format. Having >>> the option of supporting all formats would be nice. >>> >>> There was some discussion about implementing a bunch of plane properties >>> so I think having one to enumerate a set of pixel formats wouldn't be >>> such a big deal. >> >> No need for properties to expose formats, we already have that in >> getplane ioctl. But would be nice to support more than just RGBA. > > This is _just_ for the compat cursor plane setup helper. Of course we > can add whatever insane cursor formats exist out there as fourcc codes > and then drivers can add them for their custom-created cursor planes. > This is similar to the current primary plane helper code which only > exposes 32bit XRGB atm. If you want to take full advantage of this you > need to do a bit of work in your driver ;-)
oh, heh.. should have read the whole thread first :-P yeah, for compat helpers, only ARGB makes sense BR, -R > -Daniel > -- > Daniel Vetter > Software Engineer, Intel Corporation > +41 (0) 79 365 57 48 - http://blog.ffwll.ch
