On Sun, Apr 01, 2001 at 11:16:13AM -0700, Daryll Strauss wrote:
> On Sun, Apr 01, 2001 at 02:07:36PM -0400, Zephaniah E. Hull wrote:
> >
> > Actually, the problem is that libGL itself was miscompiled, I'm working
> > on tracking this down and properly fixing it.
> >
>
Actually, after a little more checking (thank god for tee and regular
expressions) it seems that the problem is that xc/lib/GL/dri/dri_glx.c
uses va_start and friends without including stdarg.h
That used to work due to either inter-dependences between other header
files which are being included, or due to va_start now being a #define
instead of a real function (I'm not sure if it was a real function
previously).
However, in either case, recent changes in libc6 and gcc in Debian
exposed this, making libGL compile but fail to work with the error in
the previous messages.
A (very simple) patch is attached.
Zephaniah E. Hull.
(Rebuilding new .debs now, but it will take around an hour and a half
just to compile.)
> Miscompiled how? I'm wondering if we "broke" it with a recent change.
>
> There was an internal discussion about whether we had to compile libGL
> with -fPIC. There is a noticable performance improvement by not doing
> that. Our understanding is that -fPIC shouldn't be required, it just
> means the image isn't shared once loaded. Getting more performance for
> some wasted memory (in the rare cases when you're running multiple
> OpenGL apps simultaneously) seems like a reasonable trade off. We tried
> leaving -fPIC off and it seemed to work on the systems we tried, but if
> it doesn't work consistently then we have a problem.
>
> So, if we're wrong in our understanding we need to know that.
>
> - |Daryll
>
--
PGP EA5198D1-Zephaniah E. Hull <[EMAIL PROTECTED]>-GPG E65A7801
Keys available at http://whitestar.soark.net/~warp/public_keys.
CCs of replies from mailing lists are encouraged.
I still do not understand why manglement believes that cutting off the
oxygen flow to the brain will INCREASE productivity. The reason they
made that decision is probably because they couldn't think clearly due
to wearing neckties.
-- Paul Tomko on ASR.
--- xc/lib/GL/dri/dri_glx.c~ Sun Apr 1 14:53:12 2001
+++ xc/lib/GL/dri/dri_glx.c Sun Apr 1 14:53:42 2001
@@ -46,6 +46,7 @@
#include <dlfcn.h>
#include "dri_glx.h"
#include <sys/types.h>
+#include <stdarg.h>
typedef void *(*CreateScreenFunc)(Display *dpy, int scrn, __DRIscreen *psc,
PGP signature
