ralf willenbacher wrote: > > Keith Whitwell wrote: > > Ralf, I haven't been able to test your patch, but it sounds like it works > > well for those who've tried it. If you clean it up to include just the agp > > texture stuff, I can commit it... > > > > Keith > > > > lets hope it works for everyone then :) >
Ralf, I've had time now to look at the patch and the problem I see with it is the kernel changes. Kernel changes are problematic because of the compatibility issues they introduce - people upgrading X but not the kernel and vice versa. >From the look of it, the changes are just to support dma texture uploads to agp memory. Using dma to upload to agp memory has one advantage: synchronization. Theoretically the rendering engine doesn't need to be flushed prior to updating texture memory in this way. However, I don't know if the mga hardware is reliable enough (and implements the right interlocks) for this to work; I seem to remember we flush the render engine before any texture uploads anyway... Using dma to upload to agp memory doesn't have any speed advantages; the dma buffer is in agp memory anyway, so you might as well go straight to the destination. Have you considered doing this (and hopefully avoiding changes to the kernel module)? Keith _________________________________________________________ Do You Yahoo!? Get your free @yahoo.com address at http://mail.yahoo.com _______________________________________________ Dri-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/dri-devel
