Bjorn Helgaas wrote: > > In the Linux AGP/GART driver, the agp_memory struct contains a memory[] > array with the physical address of every page in the block. > > Currently, the elements of the memory[] array are the actual values put > into the GATT, i.e., they contain the valid bit and any other bits > required by the GART chipset as well as the physical address. > > These mangled physical addresses are used by DRM, for example in > DRM(vm_nopage), where those extra chipset-specific bits have to be masked > out to obtain the actual physical address. > > I propose a change along the lines of the following patch, which makes the > elements of memory[] plain physical addresses and keeps all the > chipset-specific bits encapsulated inside the AGP/GART module. The > general idea is to move the "masking" (chipset-specific address mangling) > from the memory allocation path to the GATT insertion path. > > I'm not a DRM guru, so I'm sure there are subtleties I'm missing, and I > know there are some interface versioning issues to work out, but I'd > appreciate any feedback on the approach and advice on how to proceed. The > attached patch is against 2.4.16 with the IA64 patch applied. >
What are the goals of your patch? Is it a cleanup, or is there something deeper you hope to gain? Keith _________________________________________________________ Do You Yahoo!? Get your free @yahoo.com address at http://mail.yahoo.com _______________________________________________ Dri-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/dri-devel
