On Mon, Apr 01, 2002 at 08:01:58 -0700, Jens Owen wrote: > Alan Hourihane wrote: > > > > Jens, > > > > Are we moving the files in > > > > xc/programs/Xserver/hw/xfree86/os-support > > > > into their relevant ddx drivers directory ? > > If you are specifically asking about the xf86drm<DriverName>.h files in > that directory, we certainly could. There is a fair amount of cleanup > that can be done now that we down to two layers. I really tried to > minimize my changes to just the semantics of this interface, however, I > notice a couple of areas along the way that could be cleaned up: > > I) Right now, we have one os independent header file per driver: > > xc/programs/Xserver/hw/xfree86/os-support/xf86drm<driver>.h > > and one OS specific header file: > > xc/programs/Xserver/hw/xfree86/os-support/*/drm/kernel/<driver>_drm.h > > The 2D driver references the first, which is OS independent, the 3D > driver and kernel module reference the second which is not. It would be > good to get the interface down to one header only, but I think there are > some tough issues to wrestle here. > Jens,
I'm currently building the tree to test the gamma, but looking at the above again - I'm finding that.... xf86drm<driver>.h is referenced by the 2D and 3D drivers (certainly in the radeon case), and that <driver>_drm.h is only referenced by the lib/GL/dri/drm code which is right as thats coming from the symlinks for the libdrm.a code. I think we can safely move the header files from os-support/*.h to their relevant 2D ddx directories. We already include that as a search path in the 3D drivers. I think we should probably put a bigger warning in these header files though to make sure the OS maintainers know that the structures need to match in the respective kernel interfaces. Any problems with moving them now ? Alan. _______________________________________________ Dri-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/dri-devel
