On Tue, 2002-07-02 at 00:27, Tim Smith wrote: > On Monday 01 Jul 2002 10:57 pm, Michel Dänzer scribed numinously:" > > On Mon, 2002-07-01 at 23:23, Tim Smith wrote: > > > On Monday 01 Jul 2002 9:06 pm, Michel Dänzer scribed numinously:" > > > > > > > On Mon, 2002-07-01 at 21:28, Tim Smith wrote: > > > > > - BEGIN_RING( 4 ); > > > > > - OUT_RING( CP_PACKET0( RADEON_RE_TOP_LEFT, 0 ) ); > > > > > - OUT_RING( (box->y1 << 16) | box->x1 ); > > > > > - OUT_RING( CP_PACKET0( RADEON_RE_WIDTH_HEIGHT, 0 ) ); > > > > > -/* OUT_RING( ((box->y2 - 1) << 16) | (box->x2 - 1) );*/ > > > > > - OUT_RING( (box->y2 << 16) | box->x2 ); > > > > > - ADVANCE_RING(); > > > > > + BEGIN_RING( 3 ); > > > > > + OUT_RING( CP_PACKET3( RADEON_CCE_SET_SCISSORS, 1 )); > > > > > + OUT_RING( (box->y1 << 16) | box->x1 ); > > > > > + OUT_RING( (box->y2 << 16) | box->x2 ); > > > > > + ADVANCE_RING(); > > > > > > > > Add Jacek's fix to use the commented out variant with -1, and it's > > > > perfect! :) Or does the command account for that? Either way, great > > > > job. > > > > > [ snip ] > > > > I wondered about that commented-out line. I assumed (yeah, I know :-) > > > that it was there because someone was trying different things, and left > > > the one that didn't work commented out. The question I presume being > > > whether the rectangle is bottom-right inclusive of bottom-right > > > exclusive. I think it's inclusive, myself (unlike normal drawing of > > > rectangles when you specify a bottom-right corner; I think they want > > > you to use width/height) because otherwise it would be possible to have > > > a screen whose bottom right lines could never be included in the > > > clipping rectangle; you could put a pixel at 0x1FFF, 0x1FFF, but never > > > set up a clipping rectangle that allowed it to be drawn. > > > > Why not? If you have to specify w-1 and h-1, w and h can be up to 1<<16. > > You can't specify width and height for a clipping rectangle (according to > the part of docs I looked at). The register is mis-named in that instance.
D'oh, still my point stands with x2 and y2 instead of w and h. -- Earthling Michel Dänzer (MrCooper)/ Debian GNU/Linux (powerpc) developer XFree86 and DRI project member / CS student, Free Software enthusiast ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ Dri-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/dri-devel
