On Mon, 2002-07-15 at 05:21, Jens Owen wrote: > Michel Dänzer wrote: > > > On Sun, 2002-07-14 at 15:36, Keith Whitwell wrote: > > > >>Michel Dänzer wrote: > >> > >>>On Fri, 2002-07-12 at 14:56, Keith Whitwell wrote: > >>> > >>> > >>>>>Looks good, but I think I've got an even better patch: > >>>>> > >>>>>http://www.penguinppc.org/~daenzer/DRI/radeon-nommio.diff > >>>>> > >>>>>I've moved the initialization and put the scratch registers right behind > >>>>>the ring read pointer, this should work with PCI GART and all kinds of > >>>>>AGP GART. I'll commit this now. > >>>>> > >>>>> > >>>>This looks ok. The one thing I'd say is that we've added functionality to the > >>>>kernel module, so we should bump the minor version number (ie 1.4.0) -- this > >>>>means that you can test rmesa->drm.minor (or whatever) instead of firing off > >>>>the ioctl & checking for EINVAL. > >>>> > >>>> > >>>Bumping the minor strikes me as overkill for this. It's not a new ioctl > >>>or something. What about the attached patch? > >>> > >>It's a change to the interface -- an extension. It doesn't matter that it's > >>not a new ioctl, this is exactly what bumping the minor number is supposed to > >>do. Bumping the minor number is free - it doesn't cost anything or break > >>anything. > >> > >>One thing that we haven't really made clear is when a 'release' is. However, > >>given that 1.3 is in the 2.5 kernel sources, I'd say wherever the line is, > >>we've crossed it. So - bump the minor & don't worry too much. > >> > > > > You're the boss. :) Changed and committed. > > > Michel, > > Please don't think of Keith as being heavy handed.
I don't, I was just joking. > His suggestion is exactly what we need to do in order to preserve compatability. I understand that. > Thanks for working with us on this issue. Thanks for guiding me. -- Earthling Michel Dänzer (MrCooper)/ Debian GNU/Linux (powerpc) developer XFree86 and DRI project member / CS student, Free Software enthusiast ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ Dri-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/dri-devel
