On Mon, 2002-07-15 at 23:15, Mike Mestnik wrote:
> It was a copy/past job. I'm working on rewriting a lot of it, the main point of the
>patch is to
> get devfs working. The pci ids are only needed if there is more than one card(under
>linux) and
> the code was copied from BSD so I just assumed that things would work there also.
>
> I'm going to rewrite the device struct to match the one expected by linux...
>
> struct pci_device_id {
> unsigned int vendor, device; /* Vendor and device ID or
>PCI_ANY_ID */
> unsigned int subvendor, subdevice; /* Subsystem ID's or PCI_ANY_ID */
> unsigned int class, class_mask; /* (class,subclass,prog-if) triplet
>*/
> unsigned long driver_data; /* Data private to the driver */
> };
>
> 1. There is no name feild.
The name field is nice on FreeBSD so people can see what actual device
it's attaching to, and so that when I get a (limited) bug report with a
dmesg I can see it easily. It might fit into driver_data, unless that's
reserved for something else in your scheme.
> 2. There is no suported flag, so DRM_SUP can go.
Well, it removes the ability for a platform to simply not have
__REALLY_HAVE_SG (for example, this was the case on FreeBSD for quite a
while, and might be the case on a new OS, too) and by doing that not
support the PCI versions of the cards. When we support alpha on
FreeBSD, we won't have AGP for it, so it would be nice to disable
support for the AGP cards from the PCI ids (so they don't get probed as
supported cards and then attach the DRM uselessly).
What does using that linux version of the struct do to improve Linux
support? (your other mail about it confused me).
--
Eric Anholt <[EMAIL PROTECTED]>
http://people.freebsd.org/~anholt/dri/
-------------------------------------------------------
This sf.net email is sponsored by: Jabber - The world's fastest growing
real-time communications platform! Don't just IM. Build it in!
http://www.jabber.com/osdn/xim
_______________________________________________
Dri-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/dri-devel
