On Die, 2002-09-17 at 20:04, Keith Whitwell wrote: > > > PS: Shouldn't it be wake_up_interruptible_all() instead of > > wake_up_interruptible() in DRM(dma_immediate_bh)() as well? > > Maybe, please explain the difference...
AFAIUI (a kernel guru please correct me if I'm wrong), wake_up_interruptible() only wakes up one process (probably FIFO?) on the queue, whereas wake_up_interruptible_all() wakes up all of them. Hmm, after some more thinking, wake_up_interruptible() should do for SW interrupts, as they should always occur in the same order as they are emitted, but wake_up_interruptible_all() shouldn't hurt? > > PPS: The branch doesn't build completely for me: > > > > radeon_dri.c: In function `RADEONDRIAgpHeapInit': > > radeon_dri.c:848: `drmRadeonMemInitHeap' undeclared (first use in this > > function) > > radeon_dri.c:848: (Each undeclared identifier is reported only once > > radeon_dri.c:848: for each function it appears in.) > > radeon_dri.c:848: parse error before `drmHeap' > > radeon_dri.c:853: `drmHeap' undeclared (first use in this function) > > radeon_dri.c:853: `RADEON_MEM_REGION_AGP' undeclared (first use in this > > function) > > radeon_dri.c:857: `DRM_RADEON_INIT_HEAP' undeclared (first use in this > > function) > > make: *** [radeon_dri.o] Error 1 > > make: Leaving directory > > `/home/michdaen/src/dri-cvs/xc-r200/programs/Xserver/hw/xfree86/drivers/ati' > > > > That and the part of the patch above for > > programs/Xserver/hw/xfree86/os-support/linux/drm/kernel/drmP.h make me > > suspect that you've forgotten to commit some of your work, Keith? > > Yup. I just did a diff and there's heaps I forgot about. Committing now. Thanks, I've updated the patch. Looking forward to your feedback. -- Earthling Michel D�nzer (MrCooper)/ Debian GNU/Linux (powerpc) developer XFree86 and DRI project member / CS student, Free Software enthusiast ------------------------------------------------------- This SF.NET email is sponsored by: AMD - Your access to the experts on Hammer Technology! Open Source & Linux Developers, register now for the AMD Developer Symposium. Code: EX8664 http://www.developwithamd.com/developerlab _______________________________________________ Dri-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/dri-devel
