Re: [Dri-devel] radeon: two-sided lighting issues

[Keith Whitwell]

Michel Dänzer wrote:

On Fre, 2002-10-11 at 18:52, Felix Kühling wrote:

On 11 Oct 2002 18:15:08 +0200
Michel Dänzer <[EMAIL PROTECTED]> wrote:

I was looking into the lighting issues Felix reported with the
xscreensaver pulsar hack (when running it with the -light option).

[...]

One observation which confused me was that it looked good if I set the
alpha channel of global ambient to something other than 1.0 (or was it
0.0?)

I may have stumbled upon this one, see the attached patch.

Unfortunately, this doesn't fix the black roofs in bzflag, I wonder if
it helps with flightgear...




------------------------------------------------------------------------

Index: radeon_state.c
===================================================================
RCS file: /cvsroot/dri/xc/xc/lib/GL/mesa/src/drv/radeon/radeon_state.c,v
retrieving revision 1.18
diff -p -u -r1.18 radeon_state.c
--- radeon_state.c 25 Aug 2002 22:24:39 -0000 1.18
+++ radeon_state.c 12 Oct 2002 01:24:14 -0000
@@ -885,7 +885,7 @@ void radeonUpdateMaterial( GLcontext *ct
GLuint mask = ~0;
if (ctx->Light.ColorMaterialEnabled)
- mask &= ~ctx->Light.ColorMaterialBitmask;
+ mask &= ctx->Light.ColorMaterialBitmask;

The old code is correct -- if colormaterial is enabled, then calls to glMaterial should only affect the bits of the material that aren't being covered by colormaterial.

In other words, the colormaterial should reflect the current color - anything set by glMaterial is instantly overrided by the current color.

Keith




-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
Dri-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/dri-devel