Re: [Dri-devel] Possible bug in {radeon,r200}_state.c

[Keith Whitwell]

Ian Romanick wrote:

I believe that there is a bug in radeon_state.c in radeonRecaclScissorRects.
If it is a bug, then it also appears in the corresponding R200 driver.  At
line 447 there is this code block:

   rmesa->state.scissor.pClipRects =
      MALLOC( rmesa->state.scissor.numAllocedClipRects *
              sizeof(XF86DRIClipRectRec) );

   if (!rmesa->state.scissor.numAllocedClipRects) {
      rmesa->state.scissor.numAllocedClipRects = 0;
      return
   }

I believe that the if-condition should be
'!rmesa->state.scissor.pClipRects'.  Anyone have any thoughts about this?

Yes, the code's obviously bogus, and it looks like in the worst case you could end up with some incorrect scissor rectangles after a window move/resize.

Feel free to commit the obvious fix.

Keith



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
Dri-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/dri-devel