Andreas, Sorry for the delay of the reply, but I took more time to review the driver.
On Fri, Feb 28, 2003 at 05:36:54AM +0100, Andreas Karrenbauer wrote: > Jos� Fonseca wrote: > > >2. Then you have BCI (Burst Command Interface - not BCE, sorry), which > >can access to a subset of the registers. Basically it consists a memory > >region in the MMIO range where one performs consecutives writes (the > >exact address is not important, as long as the writes are consecutive) > >which are then sent to the FIFO or, if the FIFO is full, to a circular > >buffer on the framebuffer (which can be as big as 1MB). IRQ's can be > >generated with the BCI is idle. > > > This circular buffer is that "command overflow buffer" mentioned in the > savage_driver.h, right? Right. > I resolved all FIXMEs concerning the framebuffer now. I did this by > examining the radeon and the existing savage code. It was somehow hard > to distinguish between the variable names in SavagePtr structure. I am > not 100% sure whether I chose always the right one, but I tried to do it > with care. I removed a variable which I added in the last patch because > I think it was right there but with a slightly different name. The patch > is attached and it would be great if someone could review them. Yes, it seems fine to me. Commited. > If everything is okay then I will proceed with the ringbuffer. Note that the "ring buffer" here, i.e., the command overflow buffer (COB), it's never accessed directly. It's accessed indirectly via the BCI region. The card just needs to know where the COB is to do its own thing. This means that what we need to map is the BCI region. I've commited a few changes in that direction, but the actual mapping is not right yet (have to put the appropriate size of that region). I also clean up alot of Radeon'isms that were left from the copied code. Jos� Fonseca __________________________________________________ Do You Yahoo!? Everything you'll ever need on one web page from News and Sport to Email and Music Charts http://uk.my.yahoo.com ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ Dri-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/dri-devel
