On Thu, 2003-09-25 at 22:58, Linus Torvalds wrote: > On Thu, 25 Sep 2003, Dave Airlie wrote: > > > > If Linus thinks your patch goes far enough for him.. > > I actually usually don't much like whitespace changes, and the one I sent > was purely in response to the fact that there already was a lot of > whitespace changes in the i810 driver. > > Don't worry too much about it. The i810 whitespace fixes were fine - it just > became obvious that when they fixed something like > > if(x) > > to > > if (x) > > they still left strange mixes of spaces and tabs on the same line. > > All my whitespace changes was _literally_ from just editing the DRI CVS > merge diff (any lines added) before applying to the kernel tree. > > I'll happily take more whitespace fixes, I just ask that as long as you > play around with whitespace you don't do any other changes. A big > whitespace diff that also has a subtle semantic change embedded in it is > just too painful.
To me, if I was going to fix part of the whitespace in i810, I might as well fix all of the issues of the same type. diff -bu said that one was non-functional changes. Sorry about the SiS diff. I had done it all in separate stages in my perforce tree, but I didn't commit it to CVS until the work was all done. I probably should have done a two-stage commit there, I just didn't think this project cared about that. If you wanted to review the SiS stuff (which I would love for anyone to do), I have a diff of most of it. The big whitespace cleanup came after a bit of initial porting work, which involved axing a bit of dead code and using some os-independence macros. This should cover the functional changes that came after that: http://people.freebsd.org/~anholt/dri/files/sisdrm-functional.diff -- Eric Anholt [EMAIL PROTECTED] http://people.freebsd.org/~anholt/ [EMAIL PROTECTED] ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ Dri-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/dri-devel
