On Tue, 2003-10-21 at 03:35, Vladimir Dergachev wrote: > I do like the patch.
Cool. > Few questions/comments: > > 1) Did you check that it works with non-zero fbLocation ? > In particular, not all offsets need to have fbLocation added, > however, the code appears to be correct - I just worry that > it may add (or not add) fbLocation in the wrong place. It's working fine here. I noticed that you handle this quite differently in the ati.2 driver, but IMHO this way (based on Hui's patches) is cleaner. > 2) I would have expected SetFBLocation function to make sure that > the card is idle. Maybe this is done someplace else ? Not explicitly yet, but that's easy enough to add. Is there anything else to be careful about there? -- Earthling Michel Dänzer \ Debian (powerpc), XFree86 and DRI developer Software libre enthusiast \ http://svcs.affero.net/rm.php?r=daenzer ------------------------------------------------------- This SF.net email is sponsored by OSDN developer relations Here's your chance to show off your extensive product knowledge We want to know what you know. Tell us and you have a chance to win $100 http://www.zoomerang.com/survey.zgi?HRPT1X3RYQNC5V4MLNSV3E54 _______________________________________________ Dri-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/dri-devel
