On Thu, 2004-01-22 at 01:38, Roland Scheidegger wrote:
> Michel DÃnzer wrote:
>
> > you did remove only the test, not the r200UpdateMaterial() call as well,
> > right? :)
> Right, I even rechecked it...
> However, you're "suggestion" is interesting, removing the
> r200UpdateMaterial() call there works too here (for endgame at least).
That doesn't sound right.
> Removing only the state test does absolutely nothing for endgame (4.05
> or 4.14) unfortunately for me.
> Maybe we have different other patches attached?
Indeed, I had forgotten about something I had been playing with, see
attachment. Looks like the stuff in the block needs to be done
unconditionally as well?
> I'm using your http://penguinppc.org/~daenzer/DRI/r200-attenuation-2.diff
> patch
So am I; BTW, does everyone agree it's better than the first cut?
> (I also have a RV250, not R200, but let's hope this doesn't make a
> difference.)
My M9 is RV250 as well.
--
Earthling Michel DÃnzer | Debian (powerpc), X and DRI developer
Libre software enthusiast | http://svcs.affero.net/rm.php?r=daenzer
Index: r200_state.c
===================================================================
RCS file: /cvs/mesa/Mesa/src/mesa/drivers/dri/r200/r200_state.c,v
retrieving revision 1.6
diff -p -u -r1.6 r200_state.c
--- r200_state.c 27 Dec 2003 22:06:39 -0000 1.6
+++ r200_state.c 22 Jan 2004 01:19:50 -0000
@@ -963,7 +970,7 @@ void r200UpdateMaterial( GLcontext *ctx
fcmd[MTL_SHININESS] = mat[MAT_ATTRIB_FRONT_SHININESS][0];
}
- if (R200_DB_STATECHANGE( rmesa, &rmesa->hw.mtl[0] )) {
+ if (R200_DB_STATECHANGE( rmesa, &rmesa->hw.mtl[0] ) || 1) {
for (p = 0 ; p < MAX_LIGHTS; p++)
update_light_colors( ctx, p );
