Roland Scheidegger wrote:

Here's a small patch which makes color / blend logic ops work with r200/radeon (untested on radeon). It's actually a copy&paste job from the mesa sources, mesa has the comment
/* This is needed to support 1.1's RGB logic ops AND
* 1.0's blending logicops.
*/
wherever it tries to figure out if logic ops are actually enabled. Looks like a trap in the OGL specification ;-), maybe other drivers might be affected?


Patch fixes samples/blendeq and samples/blendxor (on my rv250), I hope it doesn't break anything.

Good catch.


[snip]

-   if ( ctx->Color.ColorLogicOpEnabled ) {
+   if ( ctx->Color.ColorLogicOpEnabled || (ctx->Color.BlendEnabled && mode == 
GL_LOGIC_OP)) {

There's derrived state that Mesa calculates just for this case. The test should be 'if ( ctx->Color._LogicOpEnabled )'.




-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
--
_______________________________________________
Dri-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/dri-devel

Reply via email to