Roland Scheidegger wrote:Ok then. Though as said, depending on the interaction between the
Keith Whitwell wrote:
As far as I can see though this would get very ugly, with lots
of "if drm_version" code. And it might not be necessary (for
instance if the BLENDCNTL register just "mirrors" the
CBLENDCNTL, but leaves the values in ABLENDCNTL alone then it
would be no problem at all). Maybe I'll try a bit harder to
come up with a sample application for gl_ext_blend_func_separate next week, then it would be quite
easy to figure out how the xBLENDCNTL registers interact.
I don't see why -- in userspace, just up the required drm minor number. In kernel space just define two new atoms (which happen
to overlap the old one). What's the problem?
It seems to me a rather drastic solution to make the driver incompatible to the current drm just because of some new extensions
(there are already extensions which only work if a certain drm
version is present, but the driver works just fine if the drm is a
bit older). And that blend_color is broken doesn't seem to be a
serious enough problem that the driver would absolutely require a
new drm version to run IMHO.
In other cases I would probably agree with you, but in this particular case I diagree. We're a looooooooooong time from this driver appearing in an XFree86 release, so the only people who are going to get it will be people manually installing driver updates. The alternative is, as you pointed out, some really ugly code. Not only that, we should be able to get these DRM changes into a kernel release pretty quick.
xBLENDCNTL registers, it might not really be needed. The blendcolor fix alone is really easy enough to add with a new state atom and a drm version check, without too many "ifs".
I don't think I like this neither. Sounds a bit too ugly IMHO.One other alternative, which isn't very nice either, is to conditionally compile in support for either the old or the new state atoms. Then we could have binary snapshots built either way. That way users wouldn't necessarilly be forced into a DRM upgrade as well. I don't know if I like this idea at all, but I thought it was at least worth mentioning.
Roland
------------------------------------------------------- SF.Net is sponsored by: Speed Start Your Linux Apps Now. Build and deploy apps & Web services for Linux with a free DVD software kit from IBM. Click Now! http://ads.osdn.com/?ad_id=1356&alloc_id=3438&op=click -- _______________________________________________ Dri-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/dri-devel
