Alex,

I took another close look at your patch while I was tracking down
another problem that was previously masked by the missing COB. In the
end it turned out that it was not your fault. ;-) But still, I think
this line is wrong:

     /* align cob to 128k */
->   psav->cobOffset = ((endfb - psav->cobSize + 1) + 0x20000) & ~0x20000;
     endfb = psav->cobOffset - 1;

Since you're counting backwards from the end of the frame buffer you
should be rounding downwards. And the mask should be ~0x1ffff, not
0x20000. In other words:

     /* align cob to 128k */
-    psav->cobOffset = ((endfb - psav->cobSize + 1) + 0x20000) & ~0x20000;
+    psav->cobOffset = (endfb - psav->cobSize + 1) & ~0x1ffff;
     endfb = psav->cobOffset - 1;

Regards,
  Felix

On Sat, 20 Mar 2004 09:07:55 -0800 (PST)
Alex Deucher <[EMAIL PROTECTED]> wrote:
[snip]


-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
--
_______________________________________________
Dri-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/dri-devel

Reply via email to