On Fri, 26 Mar 2004, Mike A. Harris wrote:
In XFree86 4.3.0, and also in current X.org X11, in the file:
xc/lib/GL/mesa/src/drv/r200/r200_pixel.c
[SNIP]
I'm unfamiliar with this particular code, however it seems that the same calculation being done in r200TryDrawPixels() would be valid for r200TryReadPixels().
Does the patch I've attached look correct?
Of course, 30 seconds after sending my email, I noticed that the check_color() function does not even use the "sz" parameter it is passed anywhere. Should check_color() just have that parameter removed, and all locations that use it updated to not pass that?
Yes, that would be best. The size parameter looks like it can be removed from clip_pixelrect() function as well, as it never ends up getting used.
Keith
------------------------------------------------------- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click -- _______________________________________________ Dri-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/dri-devel
