* Andrea Arcangeli ([EMAIL PROTECTED]) wrote: > On Fri, Apr 16, 2004 at 11:54:06AM -0700, Chris Wright wrote: > > + if (mc.idx >= dma->buf_count) > > + return -EINVAL; > > + > > i810_dma_dispatch_mc(dev, dma->buflist[mc.idx], mc.used, > > mc.last_render ); > > this is wrong, idx is signed, so you've to check for negative values > too. Credit for noticing this doesn't belong to me though.
Yes, you are right. I thought I had specifically checked and found it unsigned. Thanks for catching that. > Could you just in case review the other fixes too for other potential > errors like this? thanks. Yes, I'll do a double check. thanks, -chris -- Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net ------------------------------------------------------- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click -- _______________________________________________ Dri-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/dri-devel
