Re: [Dri-devel] [PATCH] Linux 2.6: Use userland firmware loading for Radeon, R128

[Nathanael Nerode]

Michel DÃnzer wrote:
On Mon, 2004-04-26 at 00:12, Nathanael Nerode wrote:

This is the most up-to-date version.  Something very similar to this
version is going into Debian's Linux kernel packages.  (Herbert Xu claims
to have removed the memcpy's in *_firmware_loader.c, though I don't
know exactly how it did it.)
                   ^^
I guess he (he's not a machine, is he? ;) uses le32_to_cpu() or a
variant thereof directly on the microcode data.
Yeah; I said *exactly* how -- I haven't seen his version of the patch.  :-)




+       if (dev_priv->is_r200)
+               filename="r200_cp_microcode";
+       else
+               filename="radeon_cp_microcode";


As discussed before, the microcode should be versioned; it might be a
good idea to start right away, e.g. "r200_cp_microcode-0" etc.
Hmm.  That would mean that a particular driver version requires a 
particular microcode version.  Is that the case?....

This is a code name which goes out of the kernel in a hotplug event. 
The current hotplug implementation simply looks for a file 
/usr/lib/hotplug/firmware/$(NAME) and copies it into the right place in 
/sys.  (Other, cleverer implementations are possible.)

It's also been suggested elsewhere that the driver module name be 
generally used as a prefix directory, so that the code name would look 
like "radeon/radeon_cp_microcode-0" -- this is still onlly 28 
characters, so it's OK....

Further naming thoughts?

-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g.
Take an Oracle 10g class now, and we'll give you the exam FREE.
http://ads.osdn.com/?ad_id149&alloc_id66&op=click
--
_______________________________________________
Dri-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/dri-devel