Adam Jackson wrote:
On Friday 28 May 2004 10:25, Ian Romanick wrote:
Roland Scheidegger wrote:

i810context.c
In file included from i810context.c:53:
../../../../../../programs/Xserver/hw/xfree86/drivers/i810/i810_dri.h:81:
parse error before "XF86DRIClipRectRec"
../../../../../../programs/Xserver/hw/xfree86/drivers/i810/i810_dri.h:81:
warning: no semicolon at end of struct
or union
../../../../../../programs/Xserver/hw/xfree86/drivers/i810/i810_dri.h:117
: parse error before '}' token
...
similar for i830.
Other drivers (didn't try all, just the default-enabled r200 mga r128
radeon gamma sis tdfx ffb) compile fine.

My changes from yesterday are likely at fault. I'll look into it.

Beat you to it. I fixed this locally last night, I was just waiting for a full make World to finish to make sure I got everything. I just committed the fixes, let me know if it works.


There was another bug in i810ioctl.c where we tried to structure-copy a drm_clip_rect_t to an XF86DRIClipRectRec. You can't do that; even if they're identical structures they can't be assigned unless they're the same type. I suspect the one ought to be typedef'd to the other (probably should define XF86... in terms of drm_clip_rect_t). In the meantime I changed the assignment to a memcpy().

The second thing on my list today is to replace all occurances of XF86DRIClipRect with drm_clip_rect_t. I'm going to start cutting the duplicate structures out of xf86drm.h / xf86dri.h. The insanity has gone on long enough! :)





-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g. Take an Oracle 10g class now, and we'll give you the exam FREE.
http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click
--
_______________________________________________
Dri-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/dri-devel

Reply via email to