Dave Airlie wrote:
On my i830 I'm getting libGL visuals errors for 4 visuals and they are all for visuals with 0 depth bits...
I've applied the following to my i830_screen.c
@@ -474,7 +475,7 @@ int depth_buffer_modes[2][2];
- depth_buffer_modes[0][0] = depth_bits; + depth_buffer_modes[0][0] = 0; //depth_bits; depth_buffer_modes[1][0] = depth_bits;
/* Just like with the accumulation buffer, always provide some modes
But I'm not sure this is correct, what would have changed that is needed now?
Ian has some other change in libGL recently caused this to crop up I don't remember seeing it before..
Unless there was some change to the i830 DDX that I didn't notice, it looks like this code has always been wrong. I'm not sure why I never saw any warnings from the driver. I'm not using the integrated graphics on my board, so I can't play with it right now.
If you're going to poke around much in that part of the driver, you might consider converting it to use driFillInModes instead of the driver-specific fill_in_modes function. :)
------------------------------------------------------- This SF.Net email is sponsored by The 2004 JavaOne(SM) Conference Learn from the experts at JavaOne(SM), Sun's Worldwide Java Developer Conference, June 28 - July 1 at the Moscone Center in San Francisco, CA REGISTER AND SAVE! http://java.sun.com/javaone/sf Priority Code NWMGYKND -- _______________________________________________ Dri-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/dri-devel
