> > > Previously all of the IOCTL calls were protected by the Big Kernel > > Lock. If we break that aren't we allowing multiple callers into the > > IOCTL code on SMP machines that weren't allowed in before? Doesn't > > that mean that we have to check everything to make sure it is SMP > > safe? > > as Alan mentioned it before, the BKL did not protect much, since the DRM > code was freely doing copying from and to userspace, and hence dropping > the BKL at those places. >
I'm not sure that the main DRM heavyweight lock doesn't stop all this from happening.. a process has to take the lock before doing anything else... it also not as if you can have two threads using the same context (correct me if I'm wrong)... granted it uses the ioctl to take the lock, but I don't think we should ever get two processes down in the driver core at the same time .. Dave. -- David Airlie, Software Engineer http://www.skynet.ie/~airlied / airlied at skynet.ie pam_smb / Linux DECstation / Linux VAX / ILUG person ------------------------------------------------------- SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media 100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33 Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift. http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285 -- _______________________________________________ Dri-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/dri-devel
