I was getting:

Badness in remove_proc_entry at fs/proc/generic.c:693
 [<c01951ba>] remove_proc_entry+0x10a/0x150
 [<dfb81925>] drm_core_exit+0x15/0x48 [drm]
 [<c01305f4>] sys_delete_module+0x144/0x180
 [<c01564d3>] do_munmap+0x143/0x180
 [<c0156554>] sys_munmap+0x44/0x70
 [<c010311f>] syscall_call+0x7/0xb

on rmmod'ing the drm module.  

my /proc/dri directory has two entries in it:
0/ and 1/

I guess it's because drm_probe is called twice for my i830.  drm_exit
only called drm_cleanup once when rmmod'ing the i830.  

lspci:

0000:00:02.0 VGA compatible controller: Intel Corp. 82852/855GM
Integrated Graphics Device (rev 02)
0000:00:02.1 Display controller: Intel Corp. 82852/855GM Integrated
Graphics Device (rev 02)

Here is a patch (don't know if it's correct?):

Signed-off-by: Aaron Straus <[EMAIL PROTECTED]>

diff -upr linux-2.6.11/drivers/char/drm/drm_drv.c 
linux-2.6.11.new/drivers/char/drm/drm_drv.c
--- linux-2.6.11/drivers/char/drm/drm_drv.c     2005-03-01 23:38:20.000000000 
-0800
+++ linux-2.6.11.new/drivers/char/drm/drm_drv.c 2005-03-13 12:06:39.000000000 
-0800
@@ -372,12 +372,12 @@ void drm_exit (struct drm_driver *driver
 
                dev = minor->dev;
                
-       }
-       if (dev) {
-               /* release the pci driver */
-               if (dev->pdev)
-                       pci_dev_put(dev->pdev);
-               drm_cleanup(dev);
+               if (dev) {
+                       /* release the pci driver */
+                       if (dev->pdev)
+                               pci_dev_put(dev->pdev);
+                       drm_cleanup(dev);
+               }
        }
        
        DRM_INFO( "Module unloaded\n" );



-- 
===================
Aaron Straus
[EMAIL PROTECTED]


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

Reply via email to