Michel DÃnzer wrote:
I also made it set the source pitch based on the image width. If the
image width is less than 64, we have a problem if the image height is
more than 1 (if the height is 1 the pitch doesn't matter). I made it
return an EINVAL error in that case. I didn't see that case ever
occurring, at least with the r300 driver.
Looks good to me as well, if this error gets triggered by the other
drivers, we can always deal with that. I'll defer to Roland for whether
this is fine for texture tiling though.
I don't think it is, very small textures (mipmaps) will have image width
of only 32 bytes, not 64 (for 32bit, 2x2 and 1x2 mips). With micro
tiling enabled, that is. Maybe it would be simpler to just use the same
pitch for source and destination, and simply explicitly remove the tile
bits.
Roland
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_ide95&alloc_id396&op=click
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
