On 6/20/05, Alan Cox <[EMAIL PROTECTED]> wrote: > On Sad, 2005-06-18 at 16:54, Jon Smirl wrote: > > How about this as a safe first step: > > 1) Remove the general root capability check > > 2) Change the semantics of the root_only field on these calls to mean > > master only. > > 3) Push the root capability check into each of these IOCTL individually. > > 4) Leave a root capability check on the general switch code to per > > device IOCTLs if they are marked master only. > > This sounds like a way to make mistakes. Far better is to make the check > a set of flags where 0/1 happen to keep their meaning > > ie > > #define DRM_NEED_ROOT 1 > #define DRM_NEED_MASTER 2 > > now anything you miss/forget to touch won't go off in your hand so to > speak.
I ended up implementing something closer to this model instead of what I suggested. The patch is up a couple of messages in this thread. I made two columns, root and master, instead of using 1/2. -- Jon Smirl [EMAIL PROTECTED] ------------------------------------------------------- SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_idt77&alloc_id492&op=click -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
