On Sun, 2005-06-26 at 19:53 -0400, Jon Smirl wrote: > On 6/26/05, Eric Anholt <[EMAIL PROTECTED]> wrote: > > I was just looking at r300 code today for my own system. A few things > > that I think ought to happen for the merge: > > - Clean up style. Unindented blocks of code, weird whitespace (closing > > brackets on the same column as the block containing it, rather than the > > surrounding block), lack of wrapping at 80 columns, etc. > > - r300_emit_unchecked_state should get renamed > > (r300_check_and_emit_state?) and its all-caps warnings removed. > > The code in DRM CVS has been run through the kernel 'scripts/Lindent' > program. There has been recent discussion on lkml about changing the > script from 80 char lines to something more modern like 120. I'd > definitely vote for 120. You will need to do some manual touch up > after Lindent. It will mess up formatting of C99 initializers and some > constant blocks.
Please, 80 is standard. > The r300 client code is added into the r200 driver, right? Not a third > library like radeon/r200/r300. It started from a copy of the r200 driver, but as far as I know the r200 support is totally broken in it, so it would go into an "r300" directory. From the last time a merge was attempted between two radeon drivers, the actual amount of shared code was small. I suspect there would be even less shared between the new one and previous drivers. It shouldn't stop merging in the future if we can show that it's a win, but I wouldn't want to wait on getting the r200 bits working again to bring the new driver in. -- Eric Anholt [EMAIL PROTECTED] http://people.freebsd.org/~anholt/ [EMAIL PROTECTED] ------------------------------------------------------- SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click -- _______________________________________________ Dri-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/dri-devel
