-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Ian Romanick wrote:
> In addition to my recent commit to Mesa CVS, try this patch.  I have
> verified that everything builds and that glxgears works on a system with
> current X.org CVS installed.

This patch *should* fix everything. :)  I built it on a system *without*
X.org 7.0rc0 on it, so there may still be build problems on those
systems.  Dunno.

I have also attached the script that I used to test on r200.  Run the
script as "./mesa_test.sh ~/devel/Mesa-build/lib ~/devel/Mesa-build".
The first parameter tells it where to find the DRI drivers (it uses it
to set DRI_DRIVERS_PATH) and the second parameter tells it where to find
Mesa's progs/demos & progs/tests.  It assumes that everything is already
made in those locations.

The only problem I hit was the following assertion in the
ARB_vertex_program tests.  I don't think that one is my fault, but it
could be.

r200_swtcl.c:103: r200SetVertexFormat: Assertion
`VB->AttribPtr[VERT_ATTRIB_POS] != ((void *)0)' failed.

I will try to test on r100, mga, and r128 tonight.  I may be able to hit
savage as well.  If somebody can try i915, unichrome, and tdfx, that
would rock.

> I'm really, really confused as to why this bug doesn't hit X.org CVS
> builds.  The only way that it would not hit is if IN_DRI_DRIVER isn't
> set.  If that's the case, it's also a bug.  I'm not sure if we should
> just apply this patch (should just need the changes to dispatch.h) to
> X.org CVS or re-import Mesa with the patch applied.  Fortunately for me,
> it's not my call to make. :)

I'm going to try and figure out what's going on with the X.org build
tomorrow (Thursday).  My guess is that IN_DRI_DRIVER isn't included in
the defines.

> As for the s/XTHREADS/USE_XTHREADS/ change, I'm not terribly happy about
> it.  The problem is that XlibConf.h contains '#define XTHREADS' to make
> it easier to build X extensions in the modular build.  This used to be
> set on the command line by imake.  My *personal* opinion is that it
> should be set on the command line by configure.

I went ahead and committed this part.

381936c4ef432d131188fe65617ec72b  Mesa-200508031610.patch.gz
6242a7bddebf1e823f09802a71db0561  mesa_test.sh
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iD8DBQFC8VIoX1gOwKyEAw8RAjvoAJ9ZR5Ok0YV6WOjB9pWNiBUHFcQC+gCfeGMh
h50ylD5bloXmpnNF5h2kMAE=
=bYu+
-----END PGP SIGNATURE-----

Attachment: Mesa-200508031610.patch.gz
Description: GNU Zip compressed data

Attachment: mesa_test.sh
Description: application/shellscript

Reply via email to