Ian Romanick wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Sergio Monteiro Basto wrote:
On Sat, 2005-12-17 at 14:20 -0800, Ian Romanick wrote:
There are several files, including
mesa/glapi/{glapioffsets,dispatch}.h
and mesa/main/{context,api_arrayelt}.c that depend on IN_DRI_DRIVER
being set properly. If it's not set, the drivers *will* be built
incorrectly. These are all pretty important.
Well this statement is important (at least to me). This means that my
patches are far way to be correct.
lib/GL/glx needs also IN_DRI_DRIVER because this dir have glapi.c from
mesa/glapi/ and Imakefile have -I$(MESASRCDIR)/src/mesa/glapi
and xc/programs/Xserver/GL/mesa also misses the Defines IN_DRI_DRIVER.
No no no no no. *NONE* of those are building DRI drivers. lib/GL/glx
builds libGL and xc/programs/Xserver/GL builds server-side GL
components. Those are not DRI drivers. If it doesn't end up being
named *_dri.so, it doesn't need IN_DRI_DRIVER defined. If it does end
up being name *_dri.so, then it *MUST* have IN_DRI_DRIVER defined.
Hmm. Looks to me like the initial patch was correct then regarding libGL
and the dri drivers - at least at first glance it looks like all files
linked into libGL.so are compiled without IN_DRI_DRIVER and all files
linked into the *_dri.so files with it. However, all files linked into
libOSMesa.so will be compiled with IN_DRI_DRIVER (since they are the
same ones as those used for the dri drivers), so I guess that won't work
neither :-( (The mesa build system doesn't have that problem as it will
never build libOSMesa and the dri drivers at the same time.). Crap...
Roland
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
