Ian Romanick wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Tilman Sauerbeck wrote:
> 
> 
>>Index: r300_context.h
>>===================================================================
>>RCS file: /cvs/mesa/Mesa/src/mesa/drivers/dri/r300/r300_context.h,v
>>retrieving revision 1.98
>>diff -u -p -r1.98 r300_context.h
>>--- r300_context.h    27 Jun 2006 01:26:47 -0000      1.98
>>+++ r300_context.h    27 Jun 2006 16:30:09 -0000
>>@@ -544,7 +544,7 @@ struct r300_vap_reg_state {
>>         int i_color[2];
>>         int i_fog;
>>         int i_tex[R300_MAX_TEXTURE_UNITS];
>>-        int i_attrib[_TNL_LAST_GENERIC-_TNL_FIRST_GENERIC];
>>+        int i_attrib[_TNL_LAST_GENERIC - _TNL_FIRST_GENERIC + 1];
>>         int i_index;
>>         int i_pointsize;
>>      };
> 
> 
> I think we should add a define _TNL_NUM_GENERIC for this.  This will
> likely happen in other drivers in the future, and I'd hate to see these
> off-by-one errors come back.

Yes, please do so.  Put it in tnl/t_context.h

-Brian


Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

Reply via email to