On Wed, 1 Nov 2006 10:50:51 -0300
Glauber de Oliveira Costa <[EMAIL PROTECTED]> wrote:

> the DRM_DEBUG macro can be called within functions very oftenly
> triggered, thus generating lots of message load and potentially
> compromising system
> 
> Signed-off-by: Glauber de Oliveira Costa <[EMAIL PROTECTED]>
> 
> -- 
> Glauber de Oliveira Costa
> Red Hat Inc.
> "Free as in Freedom"
> 
> 
> [drm_debug.patch  text/plain (444B)]
> --- linux-2.6.18.x86_64/drivers/char/drm/drmP.h.orig  2006-11-01 
> 08:00:18.000000000 -0500
> +++ linux-2.6.18.x86_64/drivers/char/drm/drmP.h       2006-11-01 
> 08:06:27.000000000 -0500
> @@ -185,7 +185,7 @@
>  #if DRM_DEBUG_CODE
>  #define DRM_DEBUG(fmt, arg...)                                               
> \
>       do {                                                            \
> -             if ( drm_debug )                        \
> +             if ( drm_debug && printk_ratelimit() )                  \
>                       printk(KERN_DEBUG                               \
>                              "[" DRM_NAME ":%s] " fmt ,       \
>                              __FUNCTION__ , ##arg);                   \


DRM_DEBUG() should be disabled in production code, and enabled only when
developers are developing stuff.  In the latter case, the developer wants
to see all the messages.

IOW, don't load the drm module with the `debug' parameter.

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

Reply via email to