Rune Petersen wrote: > Brian Paul wrote: >>It seems to me that in ctx->Driver.ProgramStringNotify() you can add any >>extra parameters you need to the program's parameters list. > > > I would prefer to make driver specific version of > _mesa_add_state_reference() for internal state vars. > > No matter how this is done, the driver needs to call add_parameter() to > safely add to the parameter list. > > Would it be all right if I made add_parameter non static?
You can't use _mesa_add_state_reference()? Perhaps a new _mesa_add_driver_state() function otherwise? >>Then, during state validation in the driver you can load/update any >>parameters you might have added. > > > I think it is a good idea. > > >>In _mesa_fetch_state() we could change the default case for switch >>(state[i]) to be silent when it sees any state tokens it doesn't >>understand (rather than call _mesa_problem()). > > Provided it is only done for STATE_INTERNAL, it should be pretty safe. > Also I was thinking adding something like STATE_INTERNAL_DRIVER or some > such so the drivers have a safe place to start adding there own vars. > >>Does that sound feasible? > > yes, and it would be less intrusive. OK. I think the next step would be for you to post a patch with whatever you need changed. Then we'll understand the details better. -Brian ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
