Keith Whitwell wrote: > Rune Petersen wrote: >> Hi, >> >> A patch for making sure VBO's are mapped breaks r300: >> >> http://marc.theaimsgroup.com/?l=mesa3d-cvs&m=116364446305536&w=2 >> >> It would appear we "just" need to add _ae_(un)map_vbos() the right >> places in radeon_vtxfmt_a.c. > > Rune, my expectation was that the change wouldn't break drivers, but > that doing the _ae_map/unmap externally would reduce the performance > impact of the change.
> I can't debug r300 unfortunately, so if adding the explict map/unmap > helps, go ahead and do so, but could you also post me stacktraces of the > crash (I assume its a crash?) so I can figure out what the underlying > problem might be? I am not that familiar with this code, I did try and all I got was a segfault in map =) Your assert caught something: backtrace: #0 0xffffe410 in __kernel_vsyscall () #1 0xa7d4c811 in raise () from /lib/tls/i686/cmov/libc.so.6 #2 0xa7d4dfb9 in abort () from /lib/tls/i686/cmov/libc.so.6 #3 0xa7d45fbf in __assert_fail () from /lib/tls/i686/cmov/libc.so.6 #4 0xa78c8bc6 in _ae_invalidate_state (ctx=0x0, new_state=4195328) at main/api_arrayelt.c:1299 #5 0xa7936a0d in _tnl_InvalidateState (ctx=0x80ebdc0, new_state=4195328) at tnl/t_context.c:158 #6 0xa78bb00a in r300InvalidateState (ctx=0x80ebdc0, new_state=4195328) at r300_state.c:1878 #7 0xa790b6ac in _mesa_update_state_locked (ctx=0x80ebdc0) at main/state.c:1107 #8 0xa790b6ea in _mesa_update_state (ctx=0x80ebdc0) at main/state.c:1118 #9 0xa793c265 in _tnl_playback_vertex_list (ctx=0x80ebdc0, data=0x8794c10) at tnl/t_save_playback.c:198 #10 0xa79399a2 in _save_compile_vertex_list (ctx=0x80ebdc0) at tnl/t_save_api.c:306 #11 0xa79399e8 in _tnl_SaveFlushVertices (ctx=0x80ebdc0) at tnl/t_save_api.c:1577 #12 0xa78e16fb in _mesa_EndList () at main/dlist.c:6814 #13 0x08050d6b in ?? () #14 0x08068fd4 in ?? () #15 0xa7f7e310 in glutMainLoop () at glut_event.c:967 #16 0x0804c02e in ?? () Rune Petersen ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel