On Mon, 2007-02-26 at 07:09 +0200, Panagiotis Papadakos wrote: 
> Well I think I have the correct patch for this. 

I'm afraid not; the test modification is incorrect. The test is an
optimization to avoid doing unnecessary work when the context is already
up to date wrt the drawables passed in and doesn't have anything to do
with the stamps.

> We should call radeonSetCliprects inside radeonMakeCurrent to update to
> the new pClipRects whenever lastStamps change.

I think that makes sense though. Maybe the updates of radeon->lastStamp
could also be moved into radeonSetCliprects and/or the common parts of
radeonMakeCurrent and r300RegainedLock moved into a separate function
called by both.

BTW, the patch also has superfluous whitespace-only changes, which
should be avoided.


-- 
Earthling Michel Dänzer           |          http://tungstengraphics.com
Libre software enthusiast         |          Debian, X and DRI developer


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

Reply via email to