Oliver McFadden wrote:
> I'd like some input on the VBO stuff in r300. In r300_context.h we have the
> following.
> 
> /* KW: Disable this code.  Driver should hook into vbo module
> * directly, see i965 driver for example.
> */
> /* #define RADEON_VTXFMT_A */
> #ifdef RADEON_VTXFMT_A
> #define HW_VBOS
> #endif
> 
> So the VTXFMT (radeon_vtxfmt_a.c) code is disabled anyway. This also 
> disables
> hardware VBOs. I guess this has been done since the new VBO branch was 
> merged.
> 
> So, the question is, should this "dead" code be removed? I think all 
> drivers are
> (or should be) moving to the new VBO code anyway.
> 
> I've already made a patch for this, but I'm not committing until I get 
> the okay
> from a few people.

I'm no expert on the R300 code so I'll defer.  Keith might have some 
comments but he's very busy with another project ATM.

On thing: I'd like to keep the trunk/master code stable for the upcoming 
7.0 release.  If you think there's some risk, let me first make the 
7.0/stable branch in git.

-Brian

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

Reply via email to