On Wednesday, May 9, 2007 8:56 am Eric Anholt wrote: > > I suspect doing it like this might break userspace expectations > > about the behaviour of the vblank counter. It would be better to do > > it similarly to how Eric Anholt did it for i915, i.e. by toggling > > the vblank interrupt in the 2D driver TransitionTo2/3D hooks. Or > > possibly even better (as this would e.g. still leave it enabled all > > the time when using a GLX compositing manager), the 3D driver could > > tell the DRM whether it needs the vblank interrupt or not. > > Yeah, I wasn't sure if the 3D driver would be able to know easily > when it might need to wait on an absolute vblank. Arjan suggested > that we not turn off the vblank when 3d is running until nobody's > waited one one for (for example) a second, and then if someone waits > on one after that, the kernel can re-enable the interrupt and > extrapolate the vblank counter using the system clock. Hiding vblank > enable/disable knowledge in the kernel sounds nicer than what I did > on i915.
Yeah, most drivers will probably have to grow power management state machines like this if we're really going to be aggressive in turning them off. I'll try to come up with a patch that does that (then on to ipw2200...). Thanks, Jesse ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel