On Wednesday, September 26, 2007 6:20 pm Ian Romanick wrote: > I have to admit that I haven't been keeping as up to date with this > thread as I should have. I've blocked off some time tomorrow morning > to fully review this patch and the discussion. I'll probably have > some questions for you, if you're on IRC.
Yeah, I'm on IRC today. > I do have one question now. What happens (or is intended to happen) > if the currently bound drawable is not a window? > > Also, the current code already deviates from the spec. :( I somehow > overlooked the bit in GLX_SGI_video_sync that says: > > glXGetVideoSyncSGI returns GLX_BAD_CONTEXT if there is no current > GLXContext. > > glXWaitVideoSyncSGI returns GLX_BAD_CONTEXT if the current context > is not direct, or if there is no current context. > > It looks like your patch maintains this behavior. Since the current > drawable can only be None if there is no context, I believe that > returning GLX_BAD_CONTEXT when getDrawable returns NULL would be > correct. So rather than the "else if" that falls back to the old screen method you'd rather see us return GLX_BAD_CONTEXT at that point? That's easy enough to fix... ping me on IRC if you see anything else. Thanks, Jesse ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
