-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Michel Dänzer wrote:
> On Wed, 2007-10-03 at 14:08 -0700, Ian Romanick wrote:
>> diff --git a/linux-core/xgi_cmdlist.c b/linux-core/xgi_cmdlist.c
>> index 261f4e1..35f7e1b 100644
>> --- a/linux-core/xgi_cmdlist.c
>> +++ b/linux-core/xgi_cmdlist.c
>> @@ -45,7 +45,7 @@ static inline void dwWriteReg(struct drm
>> DRM_INFO("mmio_map->handle = 0x%p, addr = 0x%x, data = 0x%x\n",
>> map->handle, addr, data);
>> #endif
>> - DRM_WRITE32(map, addr, data);
>> + DRM_WRITE32(map, addr, cpu_to_le32(data));
>
> These look odd - DRM_READ/WRITE* already swap bytes. Does the device's
> MMIO aperture swap bytes on its own? If so, and you can't or don't want
> to disable that, maybe we need new macros using __raw_read/write* on
> Linux.
Hmm...I didn't realize that those functions had a built-in byte-swap.
I'm having some issues getting XP10 working properly on PPC, and a
liberal sprinkling of cpu_to_le32 and le32_to_cpu made things "better."
I'll continue investigating.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
iD8DBQFHCmMPX1gOwKyEAw8RApB/AKCa0BacjZSD7eynwgOVAfI4Gz/YGwCeJqc/
aUEPIxI064kjOqjHyTw+3eM=
=zxPL
-----END PGP SIGNATURE-----
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
